Add source branch and hide common target branches in PR dashboard #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for this draft PR! Overall, I like it. Also, thanks for updating the popup. I'm not sure about the rewriting the branch name--it would then display incorrect/misleading information. I'm down for shortening, but I'd want it to look different. How about this?
|
I like that idea. Something like this? Should we do something different for not-me? Or just not shorten branches for other users? Or we could use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification
When looking at the PR dashboard, I frequently want to see the name of the source branch for a given PR. I also almost never care about the target branch, because it's usually just
mainormaster.Implementation
Add the source branch to all PRs. Hide the target branch (and related text and icon) if it's
mainormaster. Also abbreviate user branch names likeusers/kroeschl/footou/k/footo save space in the dashboard. Actually update the README and update notification.Testing
Viewed some PRs into
mainand a test PR into not-mainto verify rendering:Also verified that notification is updated and actually displays in browser: